New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the GroupID typedef with plain uint64. #132

Merged

bdarnell merged 1 commit into cockroachdb:master from bdarnell:groupid-uint64

Oct 17, 2014

Contributor

bdarnell commented Oct 17, 2014

This mirrors the earlier removal of NodeID and prepares for moving to
etcd/raft (which uses raw integer types instead of named types everywhere).

@spencerkimball @cockroachdb/developers


          Replace the GroupID typedef with plain uint64.

ac03eb0

This mirrors the earlier removal of NodeID and prepares for moving to
etcd/raft (which uses raw integer types instead of named types everywhere).

Member

spencerkimball commented Oct 17, 2014

LGTM

bdarnell added a commit that referenced this pull request


          Merge pull request #132 from bdarnell/groupid-uint64

f4105cb

Replace the GroupID typedef with plain uint64.

bdarnell merged commit f4105cb into cockroachdb:master

sourcegraphbot commented Oct 17, 2014

(*multiraft.MemoryStorage).SetGroupState(groupID multiraft.GroupID, state *multiraft.GroupPersistentState) error

func multiraft.NewMemoryStorage() *multiraft.MemoryStorage

type multiraft.Storage interface

type multiraft.EventLeaderElection struct

(multiraft.EventLeaderElection).GroupID multiraft.GroupID

type multiraft.MemoryStorage struct

(*multiraft.MemoryStorage).AppendLogEntries(groupID multiraft.GroupID, entries []*multiraft.LogEntry) error

type multiraft.SendMessageRequest struct

(multiraft.Storage).SetGroupState(groupID multiraft.GroupID, state *multiraft.GroupPersistentState) error

func multiraft.TestCommand(t *testing.T)

(*multiraft.BlockableStorage).AppendLogEntries(groupID multiraft.GroupID, entries []*multiraft.LogEntry) error

(multiraft.GroupPersistentState).GroupID multiraft.GroupID

(*multiraft.MultiRaft).ChangeGroupMembership(groupID multiraft.GroupID, changeOp multiraft.ChangeMembershipOperation, nodeID uint64) error

(*multiraft.MultiRaft).SubmitCommand(groupID multiraft.GroupID, command []byte) error

func multiraft.TestInitialLeaderElection(t *testing.T)

type multiraft.GroupPersistentState struct

(*multiraft.MultiRaft).CreateGroup(groupID multiraft.GroupID, initialMembers []uint64) error

(multiraft.SendMessageRequest).GroupID multiraft.GroupID

(multiraft.Storage).AppendLogEntries(groupID multiraft.GroupID, entries []*multiraft.LogEntry) error

func multiraft.TestMembershipChange(t *testing.T)

(*multiraft.BlockableStorage).SetGroupState(groupID multiraft.GroupID, state *multiraft.GroupPersistentState) error

type multiraft.GroupID int64

View the full smart diff on ✱ sourcegraph.com

bdarnell deleted the groupid-uint64 branch

October 17, 2014 21:23

blathers-crl bot mentioned this pull request

sql/catalog: v22.2.9: referenced descriptor ID 105: descriptor not found #105257

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet